chore(docs): add google to supported providers in ID Token doc strings #4026
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4026 +/- ##
==========================================
- Coverage 78.35% 78.35% -0.01%
==========================================
Files 370 370
Lines 26102 26108 +6
==========================================
+ Hits 20452 20456 +4
Misses 4092 4092
- Partials 1558 1560 +2 ☔ View full report in Codecov by Sentry. |
aeneasr
reviewed
Aug 7, 2024
|
No it's only implemented for Google and Apple yet. |
|
Are you sure? kratos/selfservice/strategy/oidc/strategy.go Line 706 in ad5fb09 |
|
|
That method expects the provider to implement kratos/selfservice/strategy/oidc/strategy.go Line 707 in ad5fb09 |
|
Makes sense! |
aeneasr
approved these changes
Aug 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue(s)
Checklist
introduces a new feature.
contributing code guidelines.
vulnerability. If this pull request addresses a security vulnerability, I
confirm that I got the approval (please contact
[email protected]) from the maintainers to push
the changes.
works.
Further Comments